Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issues): Remove props from group activity page #80767

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

scttcper
Copy link
Member

The goal is to remove cloneElement and passing untyped props from groupDetails down to child routes. We could also start loading sub requests earlier for some of these pages.

const childProps = {
environments,
group,
project,
event,
loadingEvent,
eventError,
groupReprocessingStatus,
onRetry: refetchData,
baseUrl,
};

The goal is to remove cloneElement and passing untyped props from groupDetails down to child routes. We could also start loading sub requests earlier for some of these pages.

https://github.com/getsentry/sentry/blob/f4a29f737fe9e46716468934b68dadb3605f03b9/static/app/views/issueDetails/groupDetails.tsx#L651-L661
@scttcper scttcper requested a review from a team as a code owner November 14, 2024 19:50
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/views/issueDetails/groupActivity.tsx 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #80767      +/-   ##
==========================================
- Coverage   78.40%   78.39%   -0.01%     
==========================================
  Files        7207     7207              
  Lines      319393   319466      +73     
  Branches    43986    44003      +17     
==========================================
+ Hits       250405   250459      +54     
- Misses      62612    62633      +21     
+ Partials     6376     6374       -2     

@scttcper scttcper merged commit 87e4fd5 into master Nov 14, 2024
45 checks passed
@scttcper scttcper deleted the scttcper/activity-props branch November 14, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants