Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): Placeholders for Web Vitals boxes #80769

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

0Calories
Copy link
Member

This improves the experience by adding placeholder cards for the web vitals while the data is loading. Previously, the vitals cards would be invisible and pop in after the data loaded, causing a very jarring layout shift.

Before

Kapture.2024-11-14.at.14.25.49.mp4

After

Kapture.2024-11-14.at.14.29.47.mp4

@0Calories 0Calories self-assigned this Nov 14, 2024
@0Calories 0Calories requested a review from a team as a code owner November 14, 2024 20:04
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ts/browser/webVitals/components/webVitalMeters.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #80769      +/-   ##
==========================================
+ Coverage   78.36%   78.41%   +0.04%     
==========================================
  Files        7211     7201      -10     
  Lines      319379   319094     -285     
  Branches    43986    43950      -36     
==========================================
- Hits       250297   250233      -64     
+ Misses      62703    62481     -222     
- Partials     6379     6380       +1     

@0Calories 0Calories merged commit 57f4022 into master Nov 14, 2024
45 checks passed
@0Calories 0Calories deleted the ash/feat/web-vitals-improve-cls branch November 14, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants