feat(crons): Implement simple incident occurence dispatching #80773
+106
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-implement-simple-incident-occurence-dispatching
branch
from
ba25e24
to
4f02b73
Compare
Simply deserializes the IncidentOccurrence messages and dispatches the incident occurrence. Does not yet determine if the clock tick should cause the dispatch to be delayed.
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-implement-simple-incident-occurence-dispatching
branch
from
4f02b73
to
cc1b540
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80773 +/- ##
==========================================
- Coverage 78.39% 78.39% -0.01%
==========================================
Files 7206 7206
Lines 319438 319458 +20
Branches 43991 43992 +1
==========================================
+ Hits 250437 250449 +12
- Misses 62620 62626 +6
- Partials 6381 6383 +2 |
JoshFerge
reviewed
Nov 14, 2024
| def has_all(checkins: list[MonitorCheckIn | None]) -> TypeGuard[list[MonitorCheckIn]]: | ||
| return None not in checkins | ||
|
|
||
| # Unlikeky, but if we can't find all the check-ins we can't produce an occurence |
There was a problem hiding this comment.
Suggested change
| # Unlikeky, but if we can't find all the check-ins we can't produce an occurence | |
| # Unlikely, but if we can't find all the check-ins we can't produce an occurence |
JoshFerge
reviewed
Nov 14, 2024
| try: | ||
| incident = MonitorIncident.objects.get(id=int(wrapper["incident_id"])) | ||
| except MonitorIncident.DoesNotExist: | ||
| return |
There was a problem hiding this comment.
worth adding a test case for this?
JoshFerge
reviewed
Nov 14, 2024
|
|
||
| # Unlikeky, but if we can't find all the check-ins we can't produce an occurence | ||
| if failed_checkin is None or not has_all(previous_checkins): | ||
| logger.error("missing_check_ins") |
There was a problem hiding this comment.
worth adding a test case for this?
JoshFerge
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply deserializes the IncidentOccurrence messages and dispatches the
incident occurrence.
Does not yet determine if the clock tick should cause the dispatch to be
delayed.