ref(crons): Move SimpleCheckIn back to just incident module #80774
+19
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80774 +/- ##
==========================================
- Coverage 78.39% 78.39% -0.01%
==========================================
Files 7206 7206
Lines 319438 319439 +1
Branches 43991 43991
==========================================
- Hits 250437 250434 -3
- Misses 62620 62623 +3
- Partials 6381 6382 +1 |
Turns out we actually really don't need to expose this type more broadly, and can just use it only in this module.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-move-simplecheckin-back-to-just-incident-module
branch
from
3ba5a1c
to
9806483
Compare
wedamija
approved these changes
Nov 14, 2024
JoshFerge
approved these changes
Nov 14, 2024
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-move-simplecheckin-back-to-just-incident-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we actually really don't need to expose this type more
broadly, and can just use it only in this module.