feat(overlay): Allow to skip sidecar #501
Open
+72
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lms24
approved these changes
Aug 21, 2024
mydea
force-pushed
the
fn/allow-disable-sidecar
branch
from
e554873 to
0ec320d
Compare
mydea
pushed a commit
that referenced
this pull request
Aug 21, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to fn/prerelease-addEnvelope, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `fn/prerelease-addEnvelope` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `fn/prerelease-addEnvelope`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @spotlightjs/[email protected] ### Minor Changes - feat(overlay): Allow to skipSidecar to avoid connecting to sidecar ([#501](#501)) ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[]: - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[[`0ec320d1259c85e3505d6a80f88dc41d0f567d9e`](0ec320d)]: - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[[`0ec320d1259c85e3505d6a80f88dc41d0f567d9e`](0ec320d)]: - @spotlightjs/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mydea
pushed a commit
that referenced
this pull request
Aug 21, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to fn/prerelease-addEnvelope, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `fn/prerelease-addEnvelope` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `fn/prerelease-addEnvelope`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[]: - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[[`28818193ba34093d456bd855c483eb61e364d14d`](2881819)]: - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - fix(overlay): Skip contextLines lookup if sidecar is empty ([#501](#501)) ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[[`28818193ba34093d456bd855c483eb61e364d14d`](2881819)]: - @spotlightjs/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
This change looks a bit invasive. Do we really need a |
BYK
requested changes
Aug 21, 2024
|
I think we can close this out? At this point we've decided that we will 1) never skip the sidecar (a variety of reasons), and 2) additionally shortcut the sidecar straight to the embed when possible |
|
I can continue to use the forked version for the chrome extension (where a sidecar is not possible), if we do not want to "fully" support this! |
|
@mydea I'll explore ways to do this automatically rather than using an explicit flag. That's why I'm keeping the PR open but I don't think we'll be moving forward with this particular PR/code change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the frontend-only use-case, we do not have a sidecar, so we want to skip connecting to it & do not show a warning for that.
ref #133