Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vinagre: Fix build and housekeeping #4347

Merged
merged 1 commit into from
Nov 15, 2024
Merged

vinagre: Fix build and housekeeping #4347

merged 1 commit into from
Nov 15, 2024

Conversation

malfisya
Copy link
Member

@malfisya malfisya commented Nov 13, 2024 •
edited
Loading

Summary

Test Plan

Launch the app

Checklist

  • Package was built and tested against unstable

@malfisya
vinagre: Fix builds and housekeeping
e2e07dd 
**Summary**

- Fix build
- Change homepage (Part of #4116)
- Add monitoring.yml (Part of #4121)
@malfisya malfisya changed the title vinagre: Housekeeping vinagre: Fix build and housekeeping Nov 13, 2024
@davidjharder
Copy link
Member

Marking this as draft until Test Plan is added

@davidjharder davidjharder marked this pull request as draft November 14, 2024 16:10
@malfisya
Copy link
Member Author

I added the test plan, I think that is good enough. I don't have anything to remote into. On another note: You know, I am in favor of deprecating this. This package is dead upstream and gnome now has built-in remote desktop right in settings. Lol.

@malfisya malfisya marked this pull request as ready for review November 15, 2024 01:03
davidjharder
davidjharder approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixup!

@davidjharder davidjharder merged commit d3958b0 into main Nov 15, 2024
1 check passed
@davidjharder davidjharder deleted the vinagre branch November 15, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjharder davidjharder davidjharder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Solus
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malfisya @davidjharder