Small ruff fixes #1177
Merged
Small ruff fixes #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegogangl
reviewed
Jan 21, 2025
| @@ -206,7 +206,7 @@ def set_bgcolor_func(self, func=None): | |||
| NOTE: This function stronglye depend on browser and could be easily | |||
| broken by changes in browser code | |||
| """ | |||
| browser = self.get_browser() | |||
| # browser = self.get_browser() | |||
There was a problem hiding this comment.
Because Ruff is complaining about the unused variable. I thought the line went with the below commented out code, so I figured commenting it out made sense?
It may be the wrong thing to do - I didn't check get_browser() for side effects
There was a problem hiding this comment.
It breaks hamster.py which uses api.browser (line 317) but it could just be replaced with get_browser()
There was a problem hiding this comment.
The assignment being commented out is that of a variable local to set_bgcolor_func() - not of PluginAPI.browser.
The line being commented out isn't actually doing anything.
This fixes a new issues found by `ruff check`. There are a few more, but they need to be looked into individually. They are instances of the code being left in an inconsistent state.
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
diegogangl
added
enhancement
maintainability
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a new issues found by
ruff check.There are a few more, but they need to be looked into individually. They are instances of the code being left in an inconsistent state.