Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New enum values for wgpu-native specific enums #294

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

rajveermalviya
Copy link
Collaborator

@rajveermalviya rajveermalviya commented Sep 16, 2023

Context

In webgpu-native meeting, it was decided to use top 16 bits as a namespace for enum values.
webgpu-native/webgpu-headers#214

Testing

Ran the examples on macos

@rajveermalviya rajveermalviya changed the title New allotted enum range New enum values for wgpu-native specific enums Sep 16, 2023
@rajveermalviya

This comment was marked as outdated.

Copy link
Collaborator

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the comment, but otherwise this LGTM.

ffi/wgpu.h Outdated Show resolved Hide resolved
Co-authored-by: Almar Klein <[email protected]>
@rajveermalviya rajveermalviya merged commit baaee05 into gfx-rs:trunk Sep 20, 2023
15 checks passed
@rajveermalviya rajveermalviya deleted the new-allotted-enum-range branch September 20, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants