Update headers #392
Merged
Update headers #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add wgpuAdapterGetInfo to replace wgpuAdapterRequestAdapterInfo. Actually implemented this time unlike wgpuAdapterRequestAdapterInfo. And wgpuAdapterInfoFreeMembers. wgpuDeviceSetUncapturedErrorCallback replaced in favor of field on instance descriptor wgpuSurfaceGetPreferredFormat deleted Add usage to WGPUSurfaceCapabilities
Just wanted something to test and figured I'd commit it. Happy to revert this commit if unwanted.
PJB3005
force-pushed
the
24-06-11-header-update
branch
from
a8ddffb
to
d4797e5
Compare
I realized while reading the WebGPU spec that returning anything other than a "normalized identifier string" there is actually illegal, which the previous value definititely was. If we want to fill these up nicely, we'll need to keep a database similar to what Dawn is doing. Hell, maybe it's best to literally use the same database for compatibility?
|
LGTM. Anyone know what the deal is with |
|
Seems like properties needs to be removed, actually: webgpu-native/webgpu-headers#304 (comment) webgpu-native/webgpu-headers#305 |
|
CI is failing because |
rajveermalviya
force-pushed
the
24-06-11-header-update
branch
from
4321623
to
7f2e37d
Compare
rajveermalviya
approved these changes
Jul 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wgpuAdapterGetInfo to replace wgpuAdapterRequestAdapterInfo. Actually implemented this time unlike wgpuAdapterRequestAdapterInfo. And wgpuAdapterInfoFreeMembers.
wgpuDeviceSetUncapturedErrorCallback replaced in favor of field on instance descriptor
wgpuSurfaceGetPreferredFormat deleted
Add usage to WGPUSurfaceCapabilities