-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create google_cloud.eno #662
Conversation
Difficult to categorise as literally any tracker pixel can be hosted here/used as an end point. This: https://dialogflow.cloud.google.com/v1/integrations/messenger/webhook/df562185-3e71-4d0b-8c94-0e73890b9453/sessions/dfMessenger-94393584 Found on: https://www.easyjet.com/en/help/preparing-to-fly/latest-travel-information
incorrect wildcard in domain list. Added filter to fix.
db/patterns/google_cloud.eno
Outdated
@@ -0,0 +1,12 @@ | |||
name: Google Cloud | |||
category: misc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "hosting" could also fit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could and I am in two minds about it. In this specific example it appears to be used as cloud hosting. But equally a cloud account could be used to host a tracker script e.g. a Meta script.
If category = "hosting" it is labelled as being benign. That would be too far my liking, but I agree "misc" is not a great fit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was looking at how we approach different examples. AWS, which should be comparable to Google Cloud, also is under "hosting":
https://github.com/ghostery/trackerdb/blob/main/db/patterns/amazon_cloudfront.eno
https://github.com/ghostery/trackerdb/blob/main/db/patterns/amazon_cdn.eno
Looks still like the best match; but it is true that what gets served from the cloud providers depends on their customers and is very broad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed to the consistency. I have updated.
Agreed - hosting is a better fit and matching other cloud providers e.g. AWS
Difficult to categorise as literally any tracker pixel can be hosted here/used as an end point.
This:
https://dialogflow.cloud.google.com/v1/integrations/messenger/webhook/df562185-3e71-4d0b-8c94-0e73890b9453/sessions/dfMessenger-94393584
Found on:
https://www.easyjet.com/en/help/preparing-to-fly/latest-travel-information