Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create google_cloud.eno #662

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Conversation

BrianClifton
Copy link
Contributor

@@ -0,0 +1,12 @@
name: Google Cloud
category: misc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "hosting" could also fit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could and I am in two minds about it. In this specific example it appears to be used as cloud hosting. But equally a cloud account could be used to host a tracker script e.g. a Meta script.

If category = "hosting" it is labelled as being benign. That would be too far my liking, but I agree "misc" is not a great fit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was looking at how we approach different examples. AWS, which should be comparable to Google Cloud, also is under "hosting":

https://github.com/ghostery/trackerdb/blob/main/db/patterns/amazon_cloudfront.eno
https://github.com/ghostery/trackerdb/blob/main/db/patterns/amazon_cdn.eno

Looks still like the best match; but it is true that what gets served from the cloud providers depends on their customers and is very broad.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed to the consistency. I have updated.

Agreed - hosting is a better fit and matching other cloud providers e.g. AWS
@philipp-classen philipp-classen merged commit 2d92960 into ghostery:main Feb 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants