Inserting numeric values (making it possible to write serial number dates/times) #379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#380 - tests are passing
I had to patch
Worksheet#[]=
method to, instead of setting@numeric_values[[row, cel]]
always to nil, to set it to the value itself if it's a numeric value or nil otherwise. Having the numeric value saved, I can use it on#save
and that's enough for Google to parse the value as numeric if adequate.Worksheet#[]=
andWorksheet#[]
APIs should be untouched, whileWorksheet#numeric_value
behaviour have changed a bit.before:
after: