Updated SHRY. Fixed the bug reported in the discussion #12 #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed the bug reported in the discussion #12.
atol
to thenp.isclose
calls incore.py
. The default value wasatol=1e-8
->atol=const.DEFAULT_ATOL
oratol = self._atol
.max_denominator=int(1 / const.DEFAULT_ATOL)
argument toto_int_dict
andinted_composition
methods in thecore.py
module.atol
(i.e., precision) if one comes across an error related to this.--atol
value in thescript.py
.default=const.DEFAULT_SYMPREC
->default=const.DEFAULT_ATOL
. Is it a bug?test_core.py
triggered bypytest
such that it uses the default values forSYMPREC
,ANGLE_TOLERANCE
, andATOL
.shry-pytest.yml
) is triggered also by a pull-request.Composition.formula
property to use our tolerance (atol
).