Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SHRY. Fixed the bug reported in the discussion #12 #13

Merged
merged 4 commits into from
Oct 1, 2023

Conversation

kousuke-nakano
Copy link
Collaborator

@kousuke-nakano kousuke-nakano commented Sep 25, 2023

I have fixed the bug reported in the discussion #12.

  • Added atol to the np.isclose calls in core.py. The default value was atol=1e-8 -> atol=const.DEFAULT_ATOL or atol = self._atol.
  • Introduced max_denominator=int(1 / const.DEFAULT_ATOL) argument to to_int_dict and inted_composition methods in the core.py module.
  • SHRY prints comments about the choice of atol (i.e., precision) if one comes across an error related to this.
  • Change the default --atol value in the script.py. default=const.DEFAULT_SYMPREC -> default=const.DEFAULT_ATOL. Is it a bug?
  • Updated test_core.py triggered by pytest such that it uses the default values for SYMPREC, ANGLE_TOLERANCE, and ATOL.
  • A GitHub action (shry-pytest.yml) is triggered also by a pull-request.
  • Added a new meta-programing line for the Composition.formula property to use our tolerance (atol).

@kousuke-nakano kousuke-nakano added bug Something isn't working enhancement New feature or request labels Sep 25, 2023
@kousuke-nakano kousuke-nakano self-assigned this Sep 25, 2023
@kousuke-nakano kousuke-nakano marked this pull request as ready for review September 25, 2023 06:38
@kousuke-nakano kousuke-nakano marked this pull request as draft September 25, 2023 13:24
@kousuke-nakano kousuke-nakano marked this pull request as ready for review September 26, 2023 04:50
@giprayogo giprayogo merged commit 510cf85 into giprayogo:devel Oct 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants