fix: New branch dropzone only accepts uncommited files #5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a brand new branch, don't let commited files or hunks create new branches
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Comment on lines
18
to
20
| if (data instanceof DraggableFile) | ||
| return !data.isCommitted && !data.files.some((f) => f.locked); | ||
| if (data instanceof DraggableHunk) return !data.isCommitted && !data.hunk.locked; |
There was a problem hiding this comment.
Can we de'morgan this and say
if (data instanceof DraggableFile)
return !(data.isCommitted || data.files.some((f) => f.locked));
if (data instanceof DraggableHunk) return !(data.isCommitted || data.hunk.locked);
Caleb-T-Owens
approved these changes
Oct 16, 2024
estib-vega
force-pushed
the
branch
branch
2 times, most recently
from
533bdb1 to
73f8133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a brand new branch, don't let committed files or hunks create new branches
Issues
As seen in #4951