Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of process calculations #358

Closed
wants to merge 8 commits into from
Closed

Out of process calculations #358

wants to merge 8 commits into from

Conversation

bard
Copy link
Contributor

@bard bard commented Nov 21, 2023 •
edited
Loading

Prep ("make the change easy") remaining to-do:

  • fix TestPriceProvider so tests also work when reading getUSDConversionRate
  • remove calculator dependency on priceProvider
  • (optionally) drop class from calculator/index.ts

To-do ("make the easy change"):

  • write self-contained script to run calculations; run through fork(); get input and return results via IPC

Opening for review so that the first prep task can be addressed.

vacekj and others added 2 commits November 21, 2023 11:39
@vacekj @bard
wip
b8c765e 
mob start [ci-skip] [ci skip] [skip ci]

mob next [ci-skip] [ci skip] [skip ci]

lastFile:src/calculator/__refactor.ts

mob next [ci-skip] [ci skip] [skip ci]

lastFile:src/test/utils.ts

mob next [ci-skip] [ci skip] [skip ci]

lastFile:src/test/calculator/proportionalMatch.test.ts

wip
@bard
lift price calculation
1374b72
@bard bard force-pushed the out-of-process-calculations branch 2 times, most recently from b02d5d7 to faeb753 Compare November 22, 2023 11:03
@bard bard force-pushed the out-of-process-calculations branch from faeb753 to 7c0666b Compare November 23, 2023 15:42
@bard bard marked this pull request as ready for review November 24, 2023 09:33
@bard bard requested a review from a team November 24, 2023 09:33
boudra
boudra reviewed Nov 27, 2023
View reviewed changes
src/calculator/index.ts Outdated Show resolved Hide resolved
boudra
boudra reviewed Nov 27, 2023
View reviewed changes
src/calculator/index.ts Outdated Show resolved Hide resolved
@bard bard linked an issue Nov 27, 2023 that may be closed by this pull request
run calculator operations in subprocess #352
Closed
@bard bard force-pushed the out-of-process-calculations branch from 6b9d497 to f3b380e Compare November 27, 2023 16:59
@boudra boudra mentioned this pull request Nov 27, 2023
Merged
boudra
boudra reviewed Nov 28, 2023
View reviewed changes
src/http/api/v1/exports.ts Outdated Show resolved Hide resolved
@bard
Copy link
Contributor Author

bard commented Dec 1, 2023

@boudra I think this is superseded, feel free to close.

@boudra
Copy link
Contributor

boudra commented Dec 11, 2023

@bard closing this PR in favour of this one (which is based off this branch): #358

@boudra boudra closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boudra boudra boudra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run calculator operations in subprocess
3 participants
@bard @boudra @vacekj