Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager: Create programs for allo v1 and v2 #3030

Merged
merged 8 commits into from
Feb 26, 2024
Merged

Conversation

boudra
Copy link
Contributor

@boudra boudra commented Feb 23, 2024

Fixes: #2976

Description

ended up mostly deleting code 🙌

  • add createProgram allo method
  • implement create program for v1 (program factory) v2 (create profile)
  • add type: program to the metadata so we can distinguish projects from programs
  • Remove create program context in favour of simple hook
  • remove context unit test in favour of create program page integration test

How to test

Loom: https://www.loom.com/share/2ea73c01bb09415a97f6e22a083b822b

Note: Profiles created in Builder will not show up in manager anymore.

  1. Create a program in Allo V2, it should show up, try with multiple operators
  2. Repeat for Allo V1

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@boudra boudra requested review from a team as code owners February 23, 2024 14:02
Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 6:19pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 6:19pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 6:19pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 6:19pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 6:19pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 6:19pm

@boudra boudra marked this pull request as draft February 23, 2024 15:49
Copy link
Contributor

@michellema1208 michellema1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boudra I'm able to create programs on v1 and v2, but for v2, it seems like it's only displaying the third program I created (left) and the first program I created (right):

Screen Shot 2024-02-23 at 1 51 17 PM

There should be 3 programs total - see Etherscan: https://sepolia.etherscan.io/address/0x37e5e6eb36467f98392ebbb35f110fbb8238e6d3. Nothing changes when I refresh the page.

I also added you as a round operator to all 3 rounds if you want to investigate!


This only happened once, but the first time I created a program, I wasn't able to open the v2 program - but then I couldn't reproduce this after creating a second program. Not sure if this is an anomaly, or if it only happens the first time you create a program.

Screen Shot 2024-02-23 at 1 44 12 PM

@boudra
Copy link
Contributor Author

boudra commented Feb 23, 2024

@michellema1208 those issues are indexer related I created two issues to investigate further.

The reason the first program didn't load when you clicked it is because of an intermittent error from cloudfront: gitcoinco/grants-stack-indexer#463

the reason your second program wasn't picked up is a tricky one, I am still investigating it, I suspect it's an intermittent Sepolia RPC issue on the indexer side. I just tried making 3 programs and they were all created for me gitcoinco/grants-stack-indexer#462 edit: found the issue and fixed here: gitcoinco/grants-stack-indexer#464

I would suggest merging this PR as there's nothing we can do to fix those issues in Grants stack

Copy link
Member

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@boudra boudra changed the title Create programs for allo v1 and v2 in manager manager: Create programs for allo v1 and v2 Feb 26, 2024
@michellema1208 michellema1208 self-requested a review February 26, 2024 18:19
@boudra boudra merged commit 7ea2b6f into main Feb 26, 2024
14 checks passed
@boudra boudra deleted the create-profile-in-manager branch February 26, 2024 18:22
Copy link

sentry-io bot commented Feb 28, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: useAllo must be used within a AlloProvider useAllo(common/src/allo/react) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manager: Create a Program/Profile on Allo v2
4 participants