fix: simplify syncRepos call in push to resolve trpc issue

[riley-kohler]

Pull Request

Proposed Changes

Our team has been facing issues with syncing not working on our deployed version of private-mirrors. Everything works locally but when deployed the syncing fails with a TRPCClientError that has no further details. Every other feature of private-mirrors is working from what we can tell and we are unsure if this issue may be affecting other private-mirrors installations. Through investigation, we attempted to get any meaningful error or debug log output but were unable to get anything helpful.

After taking a more in depth look at the implementation, we noticed that the sync functionality was the only trpc call made from the server rather than from a client browser and it seemed that there isn't much benefit to calling the sync function this way. Instead, there is added complexity by going through trpc that could be avoided by calling the function directly. This PR modifies the push handling of private-mirrors to call the syncReposHandler directly instead of going through trpc which resolves the issue that we were encountering and reduces complexity.

While it would be nice to isolate the original issue to prevent any similar future problems, this change effectively resolves the issue and even if the issue is not present in other deployments in our opinion should be merged to reduce the likelihood over other issues arising.

Any feedback would be greatly appreciated, this code is also the only area where the serverTrpc is used so that related code can be removed if desired unless it is intended to be used for another purpose. It's likely that any similar usage of serverTrpc will cause the same issue.

Readiness Checklist

Author/Contributor

• If documentation is needed for this change, has that been included in this pull request
• run npm run lint and fix any linting issues that have been introduced
• run npm run test and run tests
• If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

• Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

[Miablo]

🚢

[ahpook]

Thanks, this LGTM and makes sense - I think there may have been some ideas for additional serverTrpc usage but addressing issues that come from actual usage is more important than a working around hypothetical future problem :)