Test: Don't expect 'Source' tag when source and alert are on the same same #18653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the Source tag was required if the source and alert did not have the exact same location. This relaxes the restriction to being on the same line. Note that in order to be "on the same line" both start and end lines have to match. It's still possible for a given line to expect both Alert and Source tags, in case the source pairs up with another alert on a different line.
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
hvitved
reviewed
Feb 4, 2025
Test: Remove location parsing
hvitved
approved these changes
Feb 4, 2025
erik-krogh
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the test post-processing query so that an explicit
Sourcetag should be omitted for alerts where the source and alert location are on the same line.Previously, the
Sourcetag should be omitted when the locations were exactly the same; now they only have to be on the same line.Currently both start and end lines have to match in order to be considered on the same line.
For context, I am trying to port the JS tests to post-processed inline expectations, and I'm seeing a lot of
$ Alert Sourceexpectations that seem unnecessary.