Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv as a dependency for Ruby 3.4+ #786

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gjtorikian
Copy link

This should close #752.

As the issue says, the gem can't be used with Ruby 3.4, because csv was taken out of the Ruby standard library. csv is being used by the Gradle source.

@gjtorikian
Copy link
Author

@dangoor Any chance this can be merged and released?

@dangoor
Copy link
Contributor

dangoor commented Jan 27, 2025

@gjtorikian Thanks for your patience here. We're working on improving the maintenance of this project in the very near term.

I'll try to get your change merged in and released in the meantime, but I am very short on time right now so I can't guarantee it.

@dangoor
Copy link
Contributor

dangoor commented Jan 28, 2025

@gjtorikian Sorry, I'm running out of time on this. Can you run licensed cache to add the metadata for csv?

@gjtorikian
Copy link
Author

Sure thing, done.

@dangoor
Copy link
Contributor

dangoor commented Jan 29, 2025

@gjtorikian I don't know why licensed called the license other for csv, because it is clearly BSD-2-Clause. Because it showed up as other, we need to add it to the reviewed section of licensed.yml. Can you make that change?

@gjtorikian
Copy link
Author

done, and rebased !

@dangoor
Copy link
Contributor

dangoor commented Jan 29, 2025

@gjtorikian Sorry to say it, but I'm wary of merging the CI failure. It looks completely unrelated... Unfortunately, I didn't get a chance to finish this up (or finish moving this into its new community-driven org) before I'm going to be unavailable for a few days. I'll look to get this picked back up next week (unless someone else happens to get to it before me).

licensed should be in a better place for community contribution soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV inclusion warning for Ruby 3.4.0
3 participants