Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add an option to set the private key #2431

Merged
merged 3 commits into from
Feb 10, 2025
Merged

feat(cli): add an option to set the private key #2431

merged 3 commits into from
Feb 10, 2025

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 9, 2025

Closes #2429

@ldez ldez added this to the unreleased milestone Feb 9, 2025
@ldez ldez requested a review from dmke February 9, 2025 21:21
dmke
dmke requested changes Feb 9, 2025
View reviewed changes
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small addendum to the CLI flag, otherwise LGTM.

cmd/cmd_run.go Outdated Show resolved Hide resolved
@ldez ldez merged commit c96a165 into go-acme:master Feb 10, 2025
7 checks passed
@ldez ldez deleted the feat/cli-flag-private-key branch February 10, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmke dmke dmke approved these changes

Assignees
No one assigned
Labels
area/cli enhancement
Milestone
unreleased
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @dmke