replication: check hostname length #1013
Merged
+60
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
reviewed
Mar 11, 2025
| @@ -573,13 +573,17 @@ func (b *BinlogSyncer) writeBinlogDumpMariadbGTIDCommand(gset mysql.GTIDSet) err | |||
| return b.writeBinlogDumpCommand(mysql.Position{Name: "", Pos: 0}) | |||
| } | |||
|
|
|||
| // localHostname returns the hostname that register slave would register as. | |||
| // localHostname returns the hostname that register replica would register as. | |||
| // this gets truncated to 255 bytes. | |||
There was a problem hiding this comment.
because in the old version the length limit is 60, it's better to truncate based on MySQL version
There was a problem hiding this comment.
I don't think that's correct.
To me it looks like MySQL 9.2.0 sends a up to 255 bytes hostname to the source when registering (see register_slave_on_master() in mysql-server) even when the source it is replicating from is (much) older.
So the limitation was mostly that older version would not send a longer hostname, not that the protocol or server couldn't handle it.
lance6716
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #388