-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replication: Add mysql::serialization based Gtid Log Event #990
Merged
lance6716
merged 41 commits into
go-mysql-org:master
from
dveeden:gtid_tagged_log_event_serialized
Mar 3, 2025
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
3ea3d67
replication: Add mysql::serialization based Gtid Log Event
dveeden a3d5dee
fixup
dveeden 10158f4
fixup
dveeden 6888c31
Merge remote-tracking branch 'upstream/master' into gtid_tagged_log_e…
dveeden 09838f5
fixup
dveeden b6ceaf3
Add test and get field by name
dveeden 3bd47aa
more testing
dveeden 0b445a1
More testing
dveeden b55f86e
fixup
dveeden 3028527
prepare for negative values
dveeden 76b98bb
Update based on review
dveeden 990de1d
Merge remote-tracking branch 'upstream/master' into gtid_tagged_log_e…
dveeden 0237595
fixup
dveeden 209cfad
fixup
dveeden ad8acac
fixup
dveeden f412b2b
fixup
dveeden a7e4280
updates
dveeden b7b8f38
updates
dveeden 28d3be8
fixup
dveeden 4a8e497
More testing
dveeden c74b18e
Update serialization/serialization.go
dveeden aa11671
Merge branch 'master' into gtid_tagged_log_event_serialized
dveeden 86bf3fc
fixup
dveeden 8d78a72
formatting
dveeden ba1dcc9
Update based on review
dveeden 1558b91
Update serialization/serialization.go
dveeden da20b43
Merge branch 'master' into gtid_tagged_log_event_serialized
dveeden ab00980
Don't store the message in the event struct
dveeden 80d1d62
use map to speedup lookup of fields
dveeden 89b293f
Use decode method
dveeden a45d879
Change Size and LastNonIgnoreableField to uint8
dveeden 085c631
Change field ID to uint8
dveeden ac2d26f
Use stringParts as suggested in review
dveeden 3a1789b
fixup
dveeden 14de33c
Set original values to immediate values if skipped
dveeden 173111f
Update serialization/serialization.go
dveeden f129364
Update serialization/serialization.go
dveeden b7e35fe
test my suggestion
lance6716 78157e3
fix unit test
lance6716 9b61d61
try to fix unit test again
lance6716 dfc7475
Merge branch 'master' into gtid_tagged_log_event_serialized
lance6716 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't yet been able to generate any events with an actual
commit_group_ticket
.I first tried with
binlog_group_commit_sync_delay=...
but that didn't make any difference.Then looking at the code I noticed that this has to do with Group Replication (part of InnoDB Cluster), So I setup a cluster with 3 sandbox instances... but that also didn't give me any events for testing.
Looks like this might also be known as BGC (Binlog Group Commit) tickets.