[be] Написать бекэнд для страницы регистрации #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JOJOSoderqvist
changed the title
|
нужны тесты |
goriiin
requested changes
Sep 21, 2024
goriiin
requested changes
Sep 22, 2024
api/signup.go
Outdated
| } | ||
| } | ||
|
|
||
| func sanitizeParams(signupRequest signupApiRequest) error { |
There was a problem hiding this comment.
думаю стоит переименовать на validate
api/signup.go
Outdated
Comment on lines
12
to
15
| var signupRequest signupApiRequest | ||
| err := json.NewDecoder(r.Body).Decode(&signupRequest) | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
перенос строки после var,
убрать перенос после NewDecoder
db/db.go
Outdated
| "errors" | ||
| ) | ||
|
|
||
| var users = make(map[string]User) |
There was a problem hiding this comment.
лучше сделать отдельную структуру с sync.Mutex, так как при работе с мапой в горутинах -- неизбежная паника
api/signup.go
Outdated
| return | ||
| } | ||
|
|
||
| err = db.CreateUser(signupRequest.Email, signupRequest.User) |
There was a problem hiding this comment.
нужно хэширование пароля, используй Argon2
goriiin
approved these changes
Sep 23, 2024
HallowAz
reviewed
Sep 23, 2024
api/signup.go
Outdated
| return ErrEmptyRequestParams | ||
| } | ||
|
|
||
| if len(signupRequest.Username) < 3 || len(signupRequest.Username) > 20 { |
There was a problem hiding this comment.
minUsernameLen, maxUsernameLen (понимаете про что я)
HallowAz
reviewed
Sep 23, 2024
api/signup.go
Outdated
| return ErrWrongEmailFormat | ||
| } | ||
|
|
||
| if len(signupRequest.Password) < 5 { |
HallowAz
reviewed
Sep 23, 2024
api/types.go
Outdated
|
|
||
| type signupApiRequest struct { | ||
| Email string `json:"email"` | ||
| db.User |
HallowAz
reviewed
Sep 23, 2024
cmd/main.go
Outdated
|
|
||
| r.HandleFunc("/signup", api.SignupHandler).Methods("POST") | ||
| http.Handle("/", r) | ||
| _ = http.ListenAndServe("127.0.0.1:8080", nil) |
There was a problem hiding this comment.
если роняете сервак, лучше напишите об этом сообщение в консоль
HallowAz
approved these changes
Sep 23, 2024
JOJOSoderqvist
force-pushed
the
OZO-12
branch
from
ebafbbb
to
a0dc886
Compare
fix: Изменены тесты для регистрации improve: Изменена логика функции writeJSON()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Добавлена регистрация
P.S. Санитайзер на уровне - что в голову пришло, позже будет исправлен в соответствии с общими требованиями к санитайзингу в т.ч. на фронте