add snakecase conversion for struct fields in genStructInit #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there, first of all, thank you for this amazing project!
While experimenting with it, I came across something that seems like unusual behavior when passing arguments into a Python class constructor.
I wrote a small code in go:
After bindings generation, init looks like this:
And works as intended:
But as soon as I pass
-rename=true
flag, magic is happening. Init function does not change and gopy generates setter/getter for renamed name field:Instead of assigning the value to
name
in constructor, it creates a new property inside the Python class that is never actually used. Even if I pass a string as an argument or try using the newly created snake-cased name nothing changes. The only way is to use setter/getter methods after the class is created.This change adds snake-case conversion of
struct
fields, in__init__
the way it allows to pass variables into constructor.