ci: dont attempt to publish edge container if credentials are not present #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2981aa34f-PR-1037Details
💛 - Coveralls |
iwpnd
force-pushed
the
ci/dont-publish-edge-if-no-auth
branch
from
4400731 to
a6cf21e
Compare
ARolek
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
I think the CI is due for an overhaul, as this is just bandage for a bigger misconfiguration. I remember we had to have that default branch logic, because tegola had named default branches that'd change version to version. This is no longer the case, so we could clean that up altogether.
Might be worth looking into conventional commits and automatic release tagging using svu paired with goreleaser.