Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade project to work with the latest version of flutter #107

Merged
merged 9 commits into from
Feb 17, 2025

Conversation

brokoli18
Copy link
Contributor

@brokoli18 brokoli18 commented Feb 15, 2025

There are a few changes here all of which go towards making the project work with the latest version of flutter and compile properly. The summery of them are below

  • Upgrade/Downgrade versions of kotlin, jvm, gradle etc... to enable the app to compile
  • Run a flutter pub upgrade --major versions to upgrade dependencies in pubspec.yaml
    • We are running afowl of v1 flutter binding depreciation, so a lot of the versions of dependencies being used are broken. Most are fixed with an upgrade, however inappwebview and workmanager need the latest code to be pulled from git
    • After upgrading packages some options are no longer required and some are now mandatory. This only affected notifications.yaml and the file was updated accordingly

Flutter version:

Flutter 3.24.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 603104015d (4 months ago) • 2024-10-24 08:01:25 -0700
Engine • revision db49896cf2
Tools • Dart 3.5.4 • DevTools 2.37.3

Dart version:

Dart SDK version: 3.5.4 (stable) (Wed Oct 16 16:18:51 2024 +0000) on "linux_x64"

Resolves #106

@kolaente kolaente changed the title Upgrade project to work with the latest version of flutter feat: upgrade project to work with the latest version of flutter Feb 15, 2025
@kolaente
Copy link
Member

Looks pretty good already! Can you fix the lint errors?

@brokoli18
Copy link
Contributor Author

Looks pretty good already! Can you fix the lint errors?

I am seing some fairly strange behaavior where when I run dart format on my local machine it changes only 1 fine, but when I run the pipeline it changes 50. Dart and flutter versions are the same across both so i am not sure why its not working. Perhaps there is an analysis_options.yaml file that is downloaded on the runner? @Benimautner Have you ran into this before?

@brokoli18
Copy link
Contributor Author

I have figured it out. dart format will behave differently depending on if you have pulled all the packages or not, the pipeline currently does not pull any packages and so the formatting fails.

@kolaente I think it may be a better idea to put a step into the pipeline to do a pub get before running the format so the packages are formatted properly. What do you think?

@brokoli18
Copy link
Contributor Author

I took the liberty of tweaking the pipeline slightly to get packages before performing a format. Now it works without a problem.

Copy link
Member

@kolaente kolaente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kolaente kolaente merged commit 4a50f7d into go-vikunja:main Feb 17, 2025
2 checks passed
@Benimautner
Copy link
Collaborator

thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build project
3 participants