Null safety fixes #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k9withabone
commented
Sep 7, 2022
| @@ -14,7 +14,7 @@ class Bucket { | |||
| final List<Task> tasks; | |||
|
|
|||
| Bucket({ | |||
| this.id = -1, | |||
| this.id = 0, | |||
There was a problem hiding this comment.
Changed to 0 as discussed in #16.
lib/models/task.dart
Outdated
| DateTime? endDate, | ||
| bool? clearEndDate, |
There was a problem hiding this comment.
This allows for clearing the dates by setting them to null if the corresponding bool is true.
| @@ -43,13 +43,16 @@ getRepeatAfterValueFromDuration(Duration? repeatAfter) { | |||
| return repeatAfter.inHours; | |||
| } | |||
|
|
|||
| getDurationFromType(String? value, String? type) { | |||
| Duration? getDurationFromType(String? value, String? type) { | |||
There was a problem hiding this comment.
Added return types to make it less ambiguous.
lib/pages/list/task_edit.dart
Outdated
| endDate: _endDate, | ||
| clearEndDate: _endDate == null, |
There was a problem hiding this comment.
The dates will be null when cleared.
Benimautner
reviewed
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I got all the bugs? If there is more let me know and I'll fix them.