Dart Format #71
Merged
Dart Format #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
We should merge this first and then the other PRs. What do you think about adding this as a pipeline step as well, so that it will run every time a commit or PR is made? |
|
Sure thing. Let me do that! This is indeed the first PR that needs to be merged - otherwise you'll see in the other PRs (unless you check commit by commit) huge, unrelated changes |
kolaente
reviewed
Apr 5, 2024
| if (list.body.toString().isEmpty) return Future.value([]); | ||
| print(list.statusCode); | ||
| return convertList(list.body, (result) => TaskList.fromJson(result)); | ||
| }); | ||
| } | ||
|
|
||
| @override | ||
| Future<List<TaskList>?> getByNamespace(int namespaceId) { |
There was a problem hiding this comment.
@Benimautner Is this still used? The api endpoints don't work anymore.
There was a problem hiding this comment.
No, there's a bunch of dead code for editing lists & namespaces which should be cleaned. It's still in there bc I wanted to check whether I could adapt the pages to edit projects.
Benimautner
reviewed
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most of my PRs look like a lot has changed (because this project doesn't follow the idiomatic Dart format), this PR is the result of running:
From this PR forward, all the changes should be in the idiomatic Dart format - so that the changes won't end up looking like a huge mess.