[Queries] Respect maxResults parameter when fetching query results
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goccy
reviewed
Apr 6, 2024
goccy
reviewed
Apr 6, 2024
| @@ -581,6 +583,22 @@ func parseQueryValueAsBool(r *http.Request, key string) bool { | |||
| return b | |||
| } | |||
|
|
|||
| func parseQueryValueAsInt64(r *http.Request, key string, defaultValue int64) int64 { | |||
There was a problem hiding this comment.
If we don't need to parse other int64 values, you can use a dedicated MaxResults function. e.g.) parseMaxResultValue
There was a problem hiding this comment.
It seems likely that there may be other int64 values that we need to parse in the future, so it seems fine to leave as is
There was a problem hiding this comment.
Then I think it's ok to leave the function, just do the maxResults's validation somewhere else.
goccy
reviewed
Apr 8, 2024
| } | ||
|
|
||
| if r.maxResults != maxResultsDefaultValue { | ||
| rows = rows[:min(int64(len(rows)), r.maxResults)] |
There was a problem hiding this comment.
If -1 is set as maxResults, I think panic may occur here
There was a problem hiding this comment.
-1 is the maxResultsDefaultValue. I can add a validation for < -1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while writing the Python client regression test for goccy/go-zetasqlite#132.
Closes #262
Closes #169