Removing deprecated editor_plugin attribute key #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In godot-rust/gdext#884, editor_plugin was deprecated (automatically implied by EditorPlugin), and raises a warning when provided. Updating the docs to reflect that change.
Bromeon
reviewed
Mar 25, 2025
| <!-- TODO: more plugins from https://docs.godotengine.org/en/stable/tutorials/plugins/editor/index.html --> |
There was a problem hiding this comment.
Looks like vim fixed something automatically for me here -- the file was missing a trailing new line which was added.
I'm surprised that it's not explicitly rendered here in github's diff, but git cli diffs tell a clearer story of what changed:
❯ git diff upstream/master src/recipes/editor-plugin/index.md
...
<!-- TODO: more plugins from https://docs.godotengine.org/en/stable/tutorials/plugins/editor/index.html -->
\ No newline at end of file
<!-- TODO: more plugins from https://docs.godotengine.org/en/stable/tutorials/plugins/editor/index.html -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In godot-rust/gdext#884, editor_plugin was
deprecated (automatically implied by EditorPlugin), and raises a warning
when provided. Updating the docs to reflect that change.