Re-export gdnative_core::log again
#800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types and functions in the `log` module should remain visible and part of the public API: - `Site` is the return type of the trait method `Method::site`, and is necessary to name when implementing the trait manually e.g. for a generic method. - `print`, `warn` and `error` are safe high-level bindings to the native logging facilities that aren't available elsewhere, and are worthwhile to expose for custom `log` backend implementations that want to use call site information from the logging framework instead.
|
Good catch, thank you! I was under the impression this was only used internally. The module But I don't have a better place right now, main thing is that it's accessible and documented. There might be a few more movings coming, see "Things not (yet) done" in #788. bors r+ |
Bromeon
added
bug
c: core
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types and functions in the
logmodule should remain visible and part of the public API:Siteis the return type of the trait methodMethod::site, and is necessary to name when implementing the trait manually e.g. for a generic method.print,warnanderrorare safe high-level bindings to the native logging facilities that aren't available elsewhere, and are worthwhile to expose for customlogbackend implementations that want to use call site information from the logging framework instead.