The target all includes setup to install golint, goveralls before executing build and coverage #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected: The command
make
executes successfully.Actual: The command
make
fails with/bin/sh: 1: goveralls: not found
Potential reason: The Makefile has the
.PHONY
target:all
that may execute the targets:build
,test
,coverage
. However, the commandmake
fails as the prerequisites are not downloaded before executing the targets.What changes were made in the PR:
.PHONY
target.setup
in theall
target so thatgolint
andgoveralls
are installed before executing thebuild
andcoverage
targets.