Skip to content
This repository was archived by the owner on Jun 2, 2023. It is now read-only.

just for testing #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

just for testing #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@ linters:
- gochecknoinits
- scopelint
- dupl
- typecheck

# golangci.com configuration
# https://github.com/golangci/golangci/wiki/Configuration
service:
golangci-lint-version: 1.13.x # use fixed version to not introduce new linters unexpectedly
golangci-lint-version: 1.15.x # use fixed version to not introduce new linters unexpectedly
# suggested-changes:
# disabled: true
10 changes: 6 additions & 4 deletions internal/shared/logutil/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ package logutil
type Func func(format string, args ...interface{})

type Log interface {
Fatalf(format string, args ...interface{})
Errorf(format string, args ...interface{})
Warnf(format string, args ...interface{})
Fatalf(format string, args ...interface{})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is not gofmt-ed with -s (from gofmt)

Errorf(format string, args ...interface{})
Warnf(format string, args ...interface{})
Infof(format string, args ...interface{})
Debugf(key string, format string, args ...interface{})

Expand All @@ -15,6 +15,7 @@ type Log interface {

type LogLevel int

// setup levellign
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

levellign is a misspelling of levelling (from misspell)

Suggested change
// setup levellign
// setup levelling

const (
// debug message, write to debug logs only by logutils.Debug
LogLevelDebug LogLevel = 0
Expand All @@ -29,5 +30,6 @@ const (

// only not hidden from user errors: whole program failing, usually
// error logging happens in 1-2 places: in the "main" function.
LogLevelError LogLevel = 3
LogLevelError LogLevel = 3
)

1 change: 1 addition & 0 deletions internal/shared/logutil/stderr_log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package logutil
import (
"fmt"
"os"
"os/exec"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is not goimports-ed (from goimports)

Suggested change
"os/exec"


"github.com/golangci/golangci-lint/pkg/exitcodes"
"github.com/sirupsen/logrus" //nolint:depguard
Expand Down