Ensure the 'internal' flag is respected when calls to stop() function are enqueued #1648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Feature
I discovered a race condition when a looping HTML-backed clip would call
stop()
internally (when the clip naturally ends) and if theplayLock
happens to betrue
at that exact moment, then thestop()
call gets added to the queue. However theinternal
flag was being dropped, which meant that I was then erroneously getting anonstop
callback when the looping clip restarted.Related Issues
None I can find
Solution
The solution is to pass the
internal
flag on to the enqueuedstop()
function.Reproduction/Testing
I was able to reproduce reliably by starting several short looping clips in quick succession. At some point, if you log out the
onstop
callback, you'll see it being called when one of the clips reaches its end.Breaking Changes
N/A