Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-1840 Investigate integration with Karma GAP #374

Closed
wants to merge 2 commits into from

Conversation

aziolek
Copy link
Member

@aziolek aziolek commented Aug 1, 2024

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@aziolek aziolek self-assigned this Aug 1, 2024
@aziolek aziolek force-pushed the feature/oct-1840-karma-gap-integration branch from b29a6d0 to 0d53b6d Compare October 7, 2024 12:09
@aziolek aziolek changed the base branch from master to feature/oct-1857-octant-client-v1.5 October 7, 2024 12:09
Base automatically changed from feature/oct-1857-octant-client-v1.5 to develop October 9, 2024 10:06
@aziolek
Copy link
Member Author

aziolek commented Oct 9, 2024

Closed in favor of #491.

@aziolek aziolek closed this Oct 9, 2024
@aziolek aziolek deleted the feature/oct-1840-karma-gap-integration branch October 17, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant