Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-1548 Implement selection flow for multiple browser extension wallets #382

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

aziolek
Copy link
Member

@aziolek aziolek commented Aug 5, 2024

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@aziolek aziolek self-assigned this Aug 5, 2024
@housekeeper-bot housekeeper-bot temporarily deployed to master August 5, 2024 19:46 Destroyed
@aziolek aziolek marked this pull request as ready for review August 30, 2024 11:58
@housekeeper-bot housekeeper-bot temporarily deployed to master August 30, 2024 14:43 Destroyed
@jmikolajczyk
Copy link
Contributor

@aziolek It doesn't work. App crashes when i try to connect browser wallet.
Screenshot 2024-09-02 at 08 53 04

@housekeeper-bot housekeeper-bot temporarily deployed to master September 2, 2024 12:00 Destroyed
@aziolek
Copy link
Member Author

aziolek commented Sep 3, 2024

@aziolek It doesn't work. App crashes when i try to connect browser wallet. Screenshot 2024-09-02 at 08 53 04

@jmikolajczyk: please try again.

client/src/index.tsx Show resolved Hide resolved
client/src/locales/en/translation.json Outdated Show resolved Hide resolved
client/src/index.tsx Show resolved Hide resolved
@housekeeper-bot housekeeper-bot temporarily deployed to master September 3, 2024 12:40 Destroyed
jmikolajczyk
jmikolajczyk previously approved these changes Sep 5, 2024
@aziolek aziolek marked this pull request as draft October 31, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants