OCT-1882: Metrics: Funding leaderboard #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…882-metrics-funding-leaderboard
14 tasks
aziolek
requested changes
Sep 23, 2024
client/src/components/Metrics/MetricsProjectsListItem/MetricsProjectsListItem.module.scss
Outdated
Show resolved
Hide resolved
| {value} | ||
| {isLargeDesktop && ( | ||
| <> | ||
| <div className={styles.value} data-test={`${dataTest}__value`}> |
There was a problem hiding this comment.
There are 3 instances of the same data-test.
client/src/components/Metrics/MetricsProjectsListItem/MetricsProjectsListItem.tsx
Outdated
Show resolved
Hide resolved
client/src/components/Metrics/MetricsProjectsListItem/MetricsProjectsListItem.tsx
Outdated
Show resolved
Hide resolved
client/src/components/Metrics/MetricsProjectsListItem/MetricsProjectsListItem.tsx
Outdated
Show resolved
Hide resolved
aziolek
approved these changes
Sep 24, 2024
jmikolajczyk
merged commit c073bb3
into
feature/oct-1857-octant-client-v1.5
30 checks passed
jmikolajczyk
deleted the
feature/oct-1882-metrics-funding-leaderboard
branch
jmikolajczyk
added a commit
that referenced
this pull request
Sep 24, 2024
## Description Check after [PR-416](#416) ## Definition of Done 1. [ ] If required, the desciption of your change is added to the [QA changelog](https://www.notion.so/octantapp/Changelog-for-the-QA-d96fa3b411cf488bb1d8d9a598d88281) 2. [ ] Acceptance criteria are met. 3. [ ] PR is manually tested before the merge by developer(s). - [ ] Happy path is manually checked. 4. [ ] PR is manually tested by QA when their assistance is required (1). - [ ] Octant Areas & Test Cases are checked for impact and updated if required (2). 5. [ ] Unit tests are added unless there is a reason to omit them. 6. [ ] Automated tests are added when required. 7. [ ] The code is merged. 8. [ ] Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files). - [ ] BE: Swagger documentation is updated. 9. [ ] When required by QA: - [ ] Deployed to the relevant environment. - [ ] Passed system tests. --- (1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required. (2) [Octant Areas & Test Cases](https://docs.google.com/spreadsheets/d/1cRe6dxuKJV3a4ZskAwWEPvrFkQm6rEfyUCYwLTYw_Cc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check after PR-413
Definition of Done
(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.
(2) Octant Areas & Test Cases.