all: migrate to math/rand/v2 #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #797. Signed-off-by: Eng Zer Jun <[email protected]>
AMD64 and ARM64 seems to have small difference in float64 calculations. Reference: golang/go#36536 Signed-off-by: Eng Zer Jun <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #801 +/- ##
==========================================
+ Coverage 70.78% 72.26% +1.48%
==========================================
Files 60 59 -1
Lines 5291 7353 +2062
==========================================
+ Hits 3745 5314 +1569
- Misses 1350 1852 +502
+ Partials 196 187 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Juneezee
commented
Mar 23, 2025
There was a problem hiding this comment.
For commit 20fe218, although the differences between the AMD64 and ARM64 golden images for the Contour and Filled Line tests are not distinguishable to the human eye, there appears to be a slight difference in floating-point calculations between AMD64 and ARM64.
sbinet
previously approved these changes
Mar 23, 2025
kortschak
requested changes
Mar 24, 2025
Reference: #801 (comment) Signed-off-by: Eng Zer Jun <[email protected]>
kortschak
reviewed
Mar 25, 2025
Signed-off-by: Eng Zer Jun <[email protected]>
sbinet
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #797.
Please take a look.