Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme.md, Edit setup.py and minor update #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lbg030
Copy link

@lbg030 lbg030 commented Oct 15, 2024

Thank you for Nice work. I waited a long time for the code to be released.

As you said, I looked at readme.md and set up the environment, but there were some errors, so I solved it, and I slightly fixed what I thought was convenience.

First, I've already used the droid slam before, but due to environmental conflicts, I changed the backends function name to g_backends to form the setup.py file, and I changed "src/lib" to "thirdparty/glory_slam/lib" to solve the problem that the file does not set up due to different paths in the setup.py file.

Second, for convenience, we added a variable called image_dir so that the code to call data can be set in the config.yaml file, so that it can be called from dataset.py .

Third, the Readme.md said "gitclone --recursive https://github.com/eriksandstroem/splat-slam-private ", but there was an error that the git did not exist, so I corrected it to "gitclone --recursive https://github.com/eriksandstroem/splat-slam.git ".
and As for the pytorch version 1.12 does not support 11.7, it was modified to 1.13.1, and the latest version will be installed when you install it with the mentioned "conda install pytorch torch-cuda=11.8-c pytorch -c nvidia". So I changed it to "conda install pytorch==1.13.1 torchvision==0.14.1 torchchaudio==0.13.1 pytorch-cuda=11.7 -c pytorch -cnVIDIA" to explicitly set the version.

Copy link

google-cla bot commented Oct 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant