Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require USE_ADC_CREDENTIALS=1 to run tests. #220

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

tylere
Copy link
Collaborator

@tylere tylere commented Feb 4, 2025

Instead use ADC credentials if GOOGLE_APPLICATION_CREDENTIALS does not exist. This allows tests to be run without setting an environment variable, which is required by VSCode's Testing (test discovery and management).

Instead use ADC credentials if GOOGLE_APPLICATION_CREDENTIALS does not
exist. This allows tests to be run without setting an environment
variable, which is required by VSCode's Testing (test discovery and
management).
@tylere tylere requested review from jdbcode and naschmitz February 4, 2025 18:12
Copy link
Collaborator

@naschmitz naschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdbcode jdbcode removed their request for review February 4, 2025 19:05
@tylere
Copy link
Collaborator Author

tylere commented Feb 7, 2025

The automated tests are failing with

Error: google-github-actions/auth failed with: retry function failed after 4 attempts: the GitHub Action workflow must specify exactly one of "workload_identity_provider" or "credentials_json"! If you are specifying input values via GitHub secrets, ensure the secret is being injected into the environment. By default, secrets are not passed to workflows triggered from forks, including Dependabot.

I don't have access to the repo secrets. @naschmitz could you look at this?

@naschmitz
Copy link
Collaborator

The automated tests are failing with

Error: google-github-actions/auth failed with: retry function failed after 4 attempts: the GitHub Action workflow must specify exactly one of "workload_identity_provider" or "credentials_json"! If you are specifying input values via GitHub secrets, ensure the secret is being injected into the environment. By default, secrets are not passed to workflows triggered from forks, including Dependabot.

I don't have access to the repo secrets. @naschmitz could you look at this?

I think this is because the integration tests are running on a fork. We should be good to submit it.

Formatted README.md to *hopefully* pass mdlint
@copybara-service copybara-service bot merged commit b1c6f13 into google:main Feb 11, 2025
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants