Apply image using setImageBitmap #2650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FikriMilano
requested review from
aditya-07,
jingtang10,
MJ1998 and
santosh-pingle
as code owners
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Jul 30, 2024
- With unmerged PR #9 - WUP PR google#2178 - WUP google#2652 - WUP google#2521 - WUP google#2645 - WUP google#2648 - WUP google#2650
jingtang10
reviewed
Aug 8, 2024
There was a problem hiding this comment.
as discussed during the developers call, pls check the use of glide in the attachment widget just so we're dealing with images consistently in different parts of the sdc lib.
thanks @FikriMilano!
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Sep 4, 2024
- With unmerged PR #9 - WUP PR google#2178 - WUP google#2650
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Sep 10, 2024
FORK
- With unmerged PR #9
- WUP #13
SDK
- WUP google#2178
- WUP google#2650
- WUP google#2663
PERF
- WUP google#2669
- WUP google#2565
- WUP google#2561
- WUP google#2535
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Sep 10, 2024
- With unmerged PR #9 - WUP #13 - WUP google#2178 - WUP google#2650 - WUP google#2663
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Oct 2, 2024
FORK
- With unmerged PR #9
- WUP #13
SDK
- WUP google#2178
- WUP google#2650
- WUP google#2663
PERF
- WUP google#2669
- WUP google#2565
- WUP google#2561
- WUP google#2535
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Nov 4, 2024
FORK
- With unmerged PR #9
- WUP #13
SDK
- WUP google#2178
- WUP google#2650
- WUP google#2663
- WUP google#2689
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Nov 5, 2024
FORK
- With unmerged PR #9
- WUP #13
SDK
- WUP google#2178
- WUP google#2650
- WUP google#2663
- WUP google#2689
- WUP google#2645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2649
Description
Apply image using setImageBitmap
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Bug fix
Video
no_flicker.webm
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.