Add SUSPICIOUS_BREAKING_OUT_OF_OPTIONAL_CHAIN to SUSPICIOUS_CODE DiagnosticGroup #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's worth trying to do this despite my comments on https://groups.google.com/g/closure-compiler-discuss/c/ZpsidQkqdjk We do suppress "suspiciousCode" warnings in internal JS code that was generated from TS, so this may actually be OK. |
|
I've just imported this PR and sent it for internal testing. |
|
Good news! The test results look good, so I think I'll be able to submit the internal change, which will end up closing this PR. |
|
Awesome, thanks Bradford! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion on the Closure Compiler Discuss Group: https://groups.google.com/g/closure-compiler-discuss/c/ZpsidQkqdjk
Reasoning for change: We have set
--jscomp_error suspiciousCodein our codebase and noticed that we were getting warnings instead of errors forSUSPICIOUS_BREAKING_OUT_OF_OPTIONAL_CHAIN. We would like this to be an error instead of a warning in line with the otherDiagnosticTypesdefined in CheckSuspiciousCode