OpenGL: handle glFenceSync returning null #8419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflinger
requested changes
Feb 6, 2025
| // glFenceSync can return 0 in certain situations. For example, we've seen this happen on Web | ||
| // when the GL context has been lost. | ||
| // Unfortunately, there's not much we can do here. The fn callback will never execute, which | ||
| // could cause issues. If we've lost the WebGL context though, Filament is most likely shutting |
There was a problem hiding this comment.
It's very dangerous. e.g. the callback could be releasing a condition variable or memory.
I think I would prefer to do this only on Web (with a log); and assert in the other cases.
There was a problem hiding this comment.
Yeah that sounds reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGS = [394324805]