Update dependencies to the same version as Dawn #8460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Please add a release note line to NEW_RELEASE_NOTES.md. If this PR does not warrant a release note, add the 'internal' label to this PR. |
AndyHovingh
reviewed
Feb 20, 2025
AndyHovingh
reviewed
Feb 20, 2025
We are in the process of updating glslang, which requires set(IOS_MIN_TARGET "13.0") This is a problem since we are targeting iOS 11 in general. glslang is a filamat depedency, and we're building filamat for iOS for the iOS version of the backend test. So one solution is to set set(IOS_MIN_TARGET "13.0") for the backend test. And we might revisit this solution later. But for now, we simply disable backend tests (and filamat tests) for iOS.
bridgewaterrobbie
force-pushed
the
rbridgewater/DawnDependencyUpdate
branch
from
f15a4cb to
4958148
Compare
AndyHovingh
reviewed
Feb 21, 2025
bridgewaterrobbie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies shared between Dawn and Filament to the version used by Dawn.
BUGS=[396683691]