Add resource details display to fgviewer web view #8469
Conversation
filament/src/fg/FrameGraph.cpp
Outdated
| auto descriptor = static_cast<Resource<FrameGraphTexture> const*>( | ||
| getResource(resourceHandle))->descriptor; |
There was a problem hiding this comment.
I think this static_cast<> is not always valid right? It works right now because FrameGraphTexture is the only kind of resources we have. Maybe this deserves at least a comment?
There was a problem hiding this comment.
Updated. I add an if statement to check if the cast succeeded.
| @@ -591,4 +591,47 @@ CString to_string<filament::backend::TargetBufferFlags>(filament::backend::Targe | |||
| return { string, 6 }; | |||
| } | |||
|
|
|||
|
|
|||
| template<> | |||
| CString to_string<filament::backend::TextureFormat>(filament::backend::TextureFormat value) noexcept { | |||
There was a problem hiding this comment.
could you return a std::string_view<> instead? All these strings are static strings, so no need to do a heap allocation for them.
also I'm a little confused because this is a cpp file, so where is to_string declared?
There was a problem hiding this comment.
There's a to_string template for utils::CString, so I implemented the one for TextureFormat.
I can make the function return std::string_view, but since we store the resource properties in the class as utils::CString, even if we return a std::string_view here, we will still need to allocate a new CString then store it into the Resource::Property. WDYT?
Show some basic properties for selected resource:
Also
utils::to_stringforTextureFormatto show format as readable stringapp.js