android: prevent leak of cubemap for IndirectLight/Skybox #8470
+58
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We break existing API by returning both the IndirectLight and the texture. Same thing with Skybox. Fix one bug where the float array in getSphericalHarmonics wasn't getting written out. Fixes #6412
poweifeng
force-pushed
the
pf/android-fix-mem-leak
branch
from
70ec1fc to
613bf87
Compare
These are two utils functions (in Ktx1Loader) that exist only for Java/kotlin. It doesn't affect the java impl of IndirectLight. |
romainguy
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We break existing API by returning both the IndirectLight and the texture. Same thing with Skybox.
Fix one bug where the float array in getSphericalHarmonics wasn't getting written out.
Fixes #6412