Raise error if user uses 'name' in bridge module setup #4555
+31
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvyZX
force-pushed
the
linx_setup_name
branch
from
e066bb9 to
c8a465d
Compare
cgarciae
reviewed
Feb 19, 2025
flax/nnx/bridge/module.py
Outdated
| @@ -253,7 +256,6 @@ def variable( # type: ignore[invalid-annotation] | |||
| name: str, | |||
| init_fn: tp.Callable[..., A] | None = None, | |||
| *init_args, | |||
| unbox: bool = True, | |||
There was a problem hiding this comment.
we should leave this for compatibility?
cgarciae
reviewed
Feb 19, 2025
| @@ -123,7 +123,7 @@ def _module_meta_call(cls: type[M], *args, **kwargs) -> M: | |||
| parent = None | |||
| module: M | |||
|
|
|||
| if parent_ctx is not None and parent_ctx.in_compact: | |||
| if parent_ctx is not None: | |||
There was a problem hiding this comment.
Not sure we should go into this path when we're not inside compact. Maybe we could do the check bellow outside?
IvyZX
force-pushed
the
linx_setup_name
branch
from
c8a465d to
ee377f4
Compare
cgarciae
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.