-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve and extend Namelist file format documentation. #642
Conversation
96e4168
to
5932cdf
Compare
Great work! Please assign to me when ready to merge |
3cf4880
to
3e1d38c
Compare
@graphicore is this ready to merge? |
Uh, I missed this. Thanks. I'm rather happy with this. The biggest three issues for me right now are:
Other things can be done in a subsequent PR, like tasks derrived from #660 and #624 |
I'll tackle the remarks above later today, as far as I can. |
a29da21
to
365b807
Compare
What I did:
|
a048a4a
to
902fde5
Compare
I just removed including Note that we should probably create I'd rather do this and other changes on the encodings in a separate PR which would however depend on this PR. Or I can just add to this PR. What should I do? |
…uppercase hex values.
902fde5
to
244a625
Compare
closed by merging #685 |
Thanks!
I guess that there are a couple of things to take from that.
|
I think the key here is saying should, we'll have to update fonts from time to time to keep the glyph set definitions and the fonts in sync. @davelab6, somehow related, could you have look at this please? graphicore/specimenTools#20 |
This is a living PR for discussion. Don't merge it until we agree that it is good.