[thread_pool] topology: Use sched_getaffinity on Android API >= 12 #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_730373336
branch
2 times, most recently
from
173e82d to
77c99ce
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_730373336
branch
from
77c99ce to
623a4be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[thread_pool] topology: Use sched_getaffinity on Android API >= 12
Previously, this was done with syscall(__NR_sched_getaffinity, ...) which
doesn't get the return value right. (I saw 8 (num cpus) instead of 0.)
It's not clear whether the syscall will work correctly for old Android
versions, but we'll try to support these old versions.
sched_getaffinity/sched_setaffinity were introduced in API level 12 (Honeycomb
MR1), released in 2011. https://apilevels.com/
NDK r15c raised the minimum API target level to 14 in 2017.
https://github.com/android/ndk/wiki/Changelog-r15