Redefine AAudio_DeviceType_t #2177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AAudio_DeviceType is now defined in AOSP.
The issue is that this is a
typedef enum AAudio_DeviceType : int32_t. We can't recreate it withtypedef int32_t AAudio_DeviceType;like we do now as the types are different as the former is an enum type with a strict set of values. I propose that we create AAudio_DeviceType_t as an int32_t so at least we can cast to it.Also, it seems like Android B is NDK 29 now that we have quarterly releases.