Overrirde runnder tags #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
incident-recipient
requested changes
Jan 20, 2025
| Preconditions.checkNotNull(str, "Tag expression cannot be null!"); | ||
| Preconditions.checkNotNull(str, "Tag expression cannot be null!"); | ||
| // Check if there are tags specified using the system property "tags". | ||
| String commandLineTags = System.getProperty("tags"); |
There was a problem hiding this comment.
Please use a different property than generic "tags" to avoid collisions with other frameworks:
pdsl.filter.tags
| @@ -32,11 +32,16 @@ private static class PdslExtension extends PdslGherkinInvocationContextProvider | |||
|
|
|||
| @Override | |||
| public Stream<TestTemplateInvocationContext> provideTestTemplateInvocationContexts(ExtensionContext context) { | |||
| String defaultTagExpression = "@comment_tag#2"; | |||
| String commandLineTags = System.getProperty("tags"); | |||
There was a problem hiding this comment.
Use pdsl.filter.tags instread
| */ | ||
| public Stream<TestTemplateInvocationContext> provideTestTemplateInvocationContexts( | ||
| ExtensionContext context) { | ||
| System.setProperty("tags", "@ex_tag1"); |
There was a problem hiding this comment.
pdsl.filter.tags
| .build()) | ||
| .stream(); | ||
| // Clear command-line tags | ||
| System.clearProperty("tags"); |
There was a problem hiding this comment.
pdsl.filter.tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.